[desktop] Registry support #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarnimarun
reviewed
Nov 2, 2023
swarnimarun
reviewed
Nov 2, 2023
Janaka-Steph
force-pushed
the
registries
branch
2 times, most recently
from
bccd1e2 to
ba8812c
Compare
Janaka-Steph
force-pushed
the
registries
branch
from
2875f6d to
092b5bd
Compare
|
If I add a registry, then navigating to main page does not reflects the update unless I reload (ie/ close and reopen the app) is this a wanted behavior? Also at first load I see "No service found" only way is go Settings, remove, add again and close/reopen the app |
Janaka-Steph
force-pushed
the
registries
branch
from
9254728 to
c5d9fc6
Compare
|
Please add a button "Reset" to use the default registry URL in case the user removes all of them |
tiero
reviewed
Nov 2, 2023
Janaka-Steph
force-pushed
the
registries
branch
from
c5d9fc6 to
956433f
Compare
swarnimarun
reviewed
Nov 3, 2023
Janaka-Steph
force-pushed
the
registries
branch
from
5318495 to
89b689b
Compare
swarnimarun
reviewed
Nov 7, 2023
swarnimarun
reviewed
Nov 7, 2023
swarnimarun
reviewed
Nov 7, 2023
swarnimarun
approved these changes
Nov 7, 2023
Co-authored-by: Swarnim Arun <[email protected]>
Co-authored-by: Swarnim Arun <[email protected]>
|
cargo check fails @swarnimarun |
|
@swarnimarun Please can you properly update the code using your siggestions? It does not compile otherwise with a |
* use v1 branch of prem registry * Fix chat history (prem-research#439) * Available tag (prem-research#433) * Available tag * filter available + rm appId * rm unused var * gha: workflow_dispatch with manual version and branch name * gha: debug * gha: use version as number * v0.1.3 * remove mp3 (prem-research#432) * Update to TanStack Query v5 (prem-research#443) * fix: binary_url precedence logic (prem-research#450) * fix: binary_url precedence logic * fix: lint * Remove isFetching (prem-research#460) * fix: match premd routes with slash in docker controller (prem-research#455) * fix: gracefully handle process kill (prem-research#442) * GHA: split Tauri and Docker in two workflows (prem-research#462) * chore: add docker-compose to test app, daemon and gateway * docker-compose.gateway point to stable premd * v0.1.4 * fix: buggy state fetch (prem-research#471) * v0.1.5 --------- Co-authored-by: Janaka-Steph <[email protected]> Co-authored-by: Biswaroop <[email protected]> Co-authored-by: Swarnim Arun <[email protected]>
* Skip healthcheck * Skip healthcheck
* Petals banner * Petals banner * fiw warning
swarnimarun
suggested changes
Nov 8, 2023
Co-authored-by: Swarnim Arun <[email protected]>
Co-authored-by: Swarnim Arun <[email protected]>
Project works only for Mac M1, and we dont have binaries for Linux/Windows even |
swarnimarun
approved these changes
Nov 8, 2023
|
@tiero I think we can merge now, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fetching current registry.
Add additional registries.
It closes #454