Remove isFetching #460
Merged
Remove isFetching #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiero
pushed a commit
that referenced
this pull request
Nov 1, 2023
Janaka-Steph
added a commit
to Janaka-Steph/prem-app
that referenced
this pull request
Nov 2, 2023
Closed
tiero
added a commit
that referenced
this pull request
Nov 6, 2023
* use v1 branch of prem registry * Fix chat history (#439) * Available tag (#433) * Available tag * filter available + rm appId * rm unused var * gha: workflow_dispatch with manual version and branch name * gha: debug * gha: use version as number * v0.1.3 * remove mp3 (#432) * Update to TanStack Query v5 (#443) * fix: binary_url precedence logic (#450) * fix: binary_url precedence logic * fix: lint * Remove isFetching (#460) * fix: match premd routes with slash in docker controller (#455) * fix: gracefully handle process kill (#442) * GHA: split Tauri and Docker in two workflows (#462) * chore: add docker-compose to test app, daemon and gateway * docker-compose.gateway point to stable premd * v0.1.4 * fix: buggy state fetch (#471) * v0.1.5 --------- Co-authored-by: Janaka-Steph <[email protected]> Co-authored-by: Biswaroop <[email protected]> Co-authored-by: Swarnim Arun <[email protected]>
Janaka-Steph
added a commit
to Janaka-Steph/prem-app
that referenced
this pull request
Nov 7, 2023
* use v1 branch of prem registry * Fix chat history (prem-research#439) * Available tag (prem-research#433) * Available tag * filter available + rm appId * rm unused var * gha: workflow_dispatch with manual version and branch name * gha: debug * gha: use version as number * v0.1.3 * remove mp3 (prem-research#432) * Update to TanStack Query v5 (prem-research#443) * fix: binary_url precedence logic (prem-research#450) * fix: binary_url precedence logic * fix: lint * Remove isFetching (prem-research#460) * fix: match premd routes with slash in docker controller (prem-research#455) * fix: gracefully handle process kill (prem-research#442) * GHA: split Tauri and Docker in two workflows (prem-research#462) * chore: add docker-compose to test app, daemon and gateway * docker-compose.gateway point to stable premd * v0.1.4 * fix: buggy state fetch (prem-research#471) * v0.1.5 --------- Co-authored-by: Janaka-Steph <[email protected]> Co-authored-by: Biswaroop <[email protected]> Co-authored-by: Swarnim Arun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isFetchingwill be true during background fetch.isFetchinguse case is to display real-time updates, showing to the user that data are being refreshed.isLoadingis sufficient in our use case. Second time we navigate to Detail page, data will be served from cache.