-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to github actions CI #67
Conversation
@fsimonis does the PR look more or less sane w.r.t usage of github actions? I will also open a PR in https://github.com/precice/ci-images in a moment. (edit: see precice/ci-images#1) |
Wouldn't it be a bit more resource-friendly to run all the installation versions only if the solverdummy test succeeds? Some additional notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments. It is mainly about updating pip
when it is installed via the system's package manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
I suggest to merge it and see how it behaves on develop.
The action can always be tweaked if necessary.
One last idea: would it make sense to define dependencies between the tests to limit the amount of failing ones?
Following best practice in https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run Related to precice/precice#927
Yes and no. I like it that all tests are run in parallel and therefore finish after approx. 5 min (longest runtime: |
Trying to keep total runtime below 5mins
Closes #60
This PR adds tests for different building and installation options. This is especially useful for making sure that we do not break requirements for the spack image (such as the option
--single-version-externally-managed
).Failing tests:
setup_install
-> Will be fixed by updating dependencies ondevelop
setup_install_single_version_externally_managed
-> Will be fixed via Clean-up of setup.py #65