Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile including preCICE installation #1

Closed
wants to merge 4 commits into from

Conversation

BenjaminRodenberg
Copy link
Member

This PR contributes a Dockerfile for installing preCICE on top of ci-ubuntu-2004.

@BenjaminRodenberg
Copy link
Member Author

Important note: test_base was failing for me when I tried to build the image. I could not find an obvious reason, but will try to investigate. However, I did not run into further problems downstream when using this image (see precice/python-bindings#67).

@BenjaminRodenberg
Copy link
Member Author

7dec86f fixes the problem with the tests by using a non-root user. Ready for review.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review November 13, 2020 13:06
@fsimonis
Copy link
Member

What is the use-case for this image?

As we discussed, there will soon be a preCICE docker image which will be updated with every release.
Doesn't it fulfil your requirements?

@BenjaminRodenberg
Copy link
Member Author

on the use-case

The main use-case is the CI pipeline for the python-bindings. See precice/python-bindings#67.

on the requirements

I first tried to use https://github.com/precice/systemtests/blob/develop/precice/Dockerfile.Ubuntu2004.home for my test. However, here, curl and python3 was missing which is provided with https://github.com/precice/ci-images/blob/master/ci-ubuntu-2004.dockerfile. That's the main reason why I decided to create a new image based on ci-ubuntu-2004.

@fsimonis
Copy link
Member

fsimonis commented Dec 2, 2020

This PR is superseded by precice/precice#910

@fsimonis fsimonis closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants