AdHash bid adapter changes #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
9 tasks
muuki88
reviewed
Apr 28, 2023
| @@ -4,6 +4,7 @@ title: AdHash | |||
| description: Prebid AdHash Bidder Adapter | |||
| pbjs: true | |||
| biddercode: adhash | |||
| media_types: display, video | |||
There was a problem hiding this comment.
I would also recommend to add the multiformat_supported (will-bid-on-any, will-bid-on-one, will-not-bid ) meta information.
This indicates how your adapter behaves in the face of multi format ad units (display & video in your case)
There was a problem hiding this comment.
Thank you. Will check how the bid adapter behaves in that case with our developers and will update the documentation soon.
There was a problem hiding this comment.
I've added the requested changes.
muuki88
approved these changes
Apr 28, 2023
ecdrsvc
pushed a commit
to ecdrsvc/prebid.github.io
that referenced
this pull request
Sep 6, 2023
* AdHash documentation * multiformat_supported added * Removing globalScript flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist