AdHash Bid Adapter: changes to support preroll videos #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're operating on a com TLD now. Added publisher in URL for easier routing.
Implemented brand safety checks
Removing the extra information as request data becomes too big and is sometimes truncated
Ad fraud prevention formula changed to support negative values as well as linear distribution of article length
Adding starts-with and ends-with rules that will help us with languages such as German where a single word can be written in multiple ways depending on the gender and grammatical case.
Added support for Cyrillic characters. Added support for bidderURL parameter. Fixed score multiplier from 500 to 1000.
Support for recent ads which gives us the option to do frequency and recency capping.
Added unit tests for the analytics adapter
Removed an unneeded export of a const that was causing errors with the analytics adapter
8 tasks
|
@mkendall07 mind taking a look? This is a pretty unique integration and curious for your thoughts. |
|
@patmmccann thanks for the tag. I don't see anything particularly unusual in the change set (seems like just added instream support for the bidder). Are you referring to the |
|
Hey @mkendall07 this was a boolean flag if we want to load the library that helps us render the ad on the page or not. However this functionality is no longer used so I just removed it. I just wanted to stick our changes to the video-related things only. Cheers! |
|
Can we have the review finished, please? Or at least a time estimate when will this be done? This functionality is critical for us right now. Thank you! |
|
@wyand-sp can review asap. Can you please pull in recent commits on master because this looks to be failing from a flaky test we reworked? |
|
Sure, done. |
|
@ChrisHuie all checks have passed with the latest pull from master. |
|
@ChrisHuie any update on this review? |
|
LGTM, sorry for the delay. |
mkendall07
approved these changes
May 23, 2023
mscottnelson
added a commit
to 33Across/Prebid.js
that referenced
this pull request
Jun 2, 2023
* 33across_analytics_adapter: Adman Adapter: remove useless parameter (prebid#9967) Rise Bid Adapter: support sua and plcmt params. (prebid#9996) clean.io RTD Module: Use loadExternalScript function instead of insertElement() method to insert the Clean.io script. (prebid#9991) Bump socket.io-parser from 4.2.1 to 4.2.3 (prebid#9992) AdHash Bid Adapter: changes to support preroll videos (prebid#9870) RTB House Bid Adapter: docs update - FLEDGE support (prebid#9986) Core: fix in ortb -> legacy native asset conversion (prebid#9923) Adnuntius Bid Adaptor: Handling deals better (prebid#9943) FreeWheel SSP Adapter: add support for video.plcmt (prebid#9978) PubMatic Bid Adapter: Added support for video.plcmt (prebid#9979) Criteo Bid Adapter: add support for video.plcmt (prebid#9975) add SSP Copper6 alias adapter (prebid#9972) Criteo bid adapter: Add video outstream renderer (prebid#9955) PBS Bid Adapter: add context to emitted seatnonbid event (prebid#9804) GumGum Bid Adapter : Id5 integration suppress link type for ttd (prebid#9924) Increment version to 7.51.0-pre Prebid 7.50.0 release Docs Integration Examples : add Events UI page for Video Module (prebid#9934) LiveIntent UserId module: add support for distributorId configuration parameter (prebid#9963) Underdog Media Bid Adapter: Update ttl & referer information (prebid#9826) eps_aliasing - adding in aliases for epsilon (formerly conversant) for bidder and analytics (prebid#9961) Add mobile client hint 33x adapter (prebid#9958) confiant Rtd Provider : add message type check (prebid#9950) Criteo Bid Adapter: add support for imp.rwdd (prebid#9964) Yahoo SSP adapter support for extra site publisher info. (prebid#9921) RubiconBidAdapter: sync parseSize algorithm for isBidRequestValid and ortb conversion (prebid#9957) Ticket: IDG-829
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
* AdHash Bidder Adapter: minor changes We're operating on a com TLD now. Added publisher in URL for easier routing. * Implemented brand safety Implemented brand safety checks * Fix for GDPR consent Removing the extra information as request data becomes too big and is sometimes truncated * Ad fraud prevention formula changed Ad fraud prevention formula changed to support negative values as well as linear distribution of article length * AdHash brand safety additions Adding starts-with and ends-with rules that will help us with languages such as German where a single word can be written in multiple ways depending on the gender and grammatical case. * AdHash brand safety updates Added support for Cyrillic characters. Added support for bidderURL parameter. Fixed score multiplier from 500 to 1000. * AdHash Analytics adapter * Support for recent ads Support for recent ads which gives us the option to do frequency and recency capping. * Fix for timestamp * PUB-222 Added logic for measuring the fill rate (fallbacks) for Prebid impressions * Unit tests for the analytics adapter Added unit tests for the analytics adapter * Removed export causing errors Removed an unneeded export of a const that was causing errors with the analytics adapter * Added globalScript parameter * PUB-227 Support for non-latin and non-cyrillic symbols * GEN-964 - Brand safety now checks the page URL for bad words. No ad is shown if there is at least one match. - Repeating code is optimized and moved to helper function - Multi-language support for brand safety * GEN-1025 Sending the needed ad density data to the bidder * Removing the analytics adaptor * Fix for regexp match * Version change * MINOR Code review changes * GEN-1153 Adding support for preroll ads * MINOR Video unit test added * Removing globalScript flag --------- Co-authored-by: NikolayMGeorgiev <[email protected]> Co-authored-by: Ventsislav Saraminev <[email protected]> Co-authored-by: Dimitar Kalenderov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added support to AdHash bid adapter for video prerolls.
Other information
PR to documentation change: prebid/prebid.github.io#4527