-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveintent user module docs added. #1493
Conversation
changed the paragraph about the LiveIntent ID solution and added an email address to reach out to to get your fpc universe setup
fixed typo, added to implementation section
Thanks @jankoulaga - We need to update the Prebid Server bid adapter to pass your value through OpenRTB. What
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any mention of the segment Id/s being passed?
Hey @bretg, let's go with |
Hey @jdwieland8282 the segments part in the response will be wrapped inside, depending whether any segment actually exist on our end. At the time when we were writing these docs, we we're still investigating which segments will actually be added in the response, ad we thought it might be better to update these once we know more. WDYT? |
dev-docs/modules/userId.md
Outdated
| DigiTrust | IAB | bidRequest.userId.digitrustid | `{data: {id: "DTID", keyv: 4, privacy: {optout: false}, producer: "ABC", version: 2}` | | ||
| ID5 ID | ID5 | bidRequest.userId.id5id | `"ID5-12345"` | | ||
| ID5 ID | ID5 | bidRequest.userId.id5id | `"1111"` | | ||
| IdentityLink | Trade Desk | bidRequest.userId.identityLink | `"1111"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for IdentityLink, it is bidRequest.userId.idl_env
https://github.com/prebid/Prebid.js/blob/master/modules/identityLinkIdSystem.js#L26
Let me know if i have mis-understood :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idl_env is correct. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be some mention of the segment id that gets passed from the liveintent sub module.
@jdwieland8282 i've mentioned the segments and tried to cover it with an example in the userId object. |
…/prebid.github.io into liveintent-user-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating.
dev-docs/modules/userId.md
Outdated
| ID5 ID | ID5 | bidRequest.userId.id5id | `"ID5-12345"` | | ||
| ID5 ID | ID5 | bidRequest.userId.id5id | `"1111"` | | ||
| IdentityLink | Trade Desk | bidRequest.userId.idl_env | `"1111"` | | ||
| LiveIntent ID | Live Intent | bidRequest.userId.liveIntentId | `"1111"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jankoulaga , @bretg
I see that in bidRequest object LiveIntent Id is passed as , bidUserId.lipb.lipbid
Refer: https://github.com/prebid/Prebid.js/pull/4178/files#diff-93e5cbcbb2aa2045b6e254010a1fc6b4R729
But in docs here, it is mentioned as bidRequest.userId.liveIntentId
Can you please check and let us know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @pm-harshad-mane. The path should be correct now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jankoulaga !!
released with 2.36 |
This reflects changes made in prebid/Prebid.js#4178