Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent Identity Module. #4178

Merged
merged 19 commits into from
Oct 14, 2019
Merged

Conversation

jankoulaga
Copy link
Contributor

@jankoulaga jankoulaga commented Sep 10, 2019

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

This PR introduces the LiveIntent Id module. For it's purpose, there are a couple config params we've imagined(outside of the standard storage part) would be useful for us. Here's an example of such a config with descriptions.

{
	name: 'liveIntentId',
	params: {
		publisherId: '7798696', // MANDATORY : Set an identifier of a publisher know to your systems 
		identifiersToResolve: ['tdid'], // OPTIONAL : Choose which additional values will be sent along to improve resolution. Those will be fetched from LS || Cookie space  
		url: 'https://liveintent.yourdomain.com' // OPTIONAL : If we already live under your domain, we can use the internal URI. If not set, a default on will be used.
	},
	storage: {
		type: 'cookie',
		name: '_li_pbid',
		expires: 60
	}
}

@bretg
Copy link
Collaborator

bretg commented Sep 10, 2019

@pm-harshad-mane
Copy link
Contributor

Hello @jankoulaga ,
Can you please add details about how an adapter can consume LiveIntent Id?
Other UserId submodules have shared the info here, http://prebid.org/dev-docs/modules/userId.html#prebidjs-adapters

@jankoulaga
Copy link
Contributor Author

Hey @pm-harshad-mane, we're still working on the docs portion and i assume it those will be distributed accordingly. Hang tight :)

@jankoulaga
Copy link
Contributor Author

Docs pr was created:
prebid/prebid.github.io#1493

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jankoulaga, to review this PR, I tried to rerun the test build but it's failing. Can you fix this first?

@jankoulaga
Copy link
Contributor Author

Hi @sumit116, can i get some details on what's exactly failing?

@jankoulaga jankoulaga requested a review from sumit116 September 24, 2019 14:32
modules/userId/index.js Outdated Show resolved Hide resolved
@idettman
Copy link
Contributor

idettman commented Oct 4, 2019

can you add your submodule to the modules/.submodules.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants