Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanmedia to partners #1112

Closed

Conversation

sa1omon
Copy link
Contributor

@sa1omon sa1omon commented Jan 22, 2019

No description provided.

@sa1omon sa1omon changed the title Add cleanmedia to partners branch Add cleanmedia to partners Jan 22, 2019
bretg added 2 commits January 28, 2019 11:17
sorry - the _bidders directory is a mistake on our part. dev-docs/bidders is where the .md files reside.
sorry - the _bidders directory is a mistake on our part. dev-docs/bidders is where the .md files reside
@bretg
Copy link
Contributor

bretg commented Jan 28, 2019

Sorry @sa1omon - the _bidders directory was a mistake on our part, we're removing. I've removed changes from this PR related to that directory.

What is it you're trying to achieve? Are you ready to fully rename gambid to gamoshi and get rid of gambid? (That's what I recall you wanted to do at some point?)

@bretg bretg added the question label Jan 28, 2019
@sa1omon
Copy link
Contributor Author

sa1omon commented Jan 29, 2019

Sorry @sa1omon - the _bidders directory was a mistake on our part, we're removing. I've removed changes from this PR related to that directory.

What is it you're trying to achieve? Are you ready to fully rename gambid to gamoshi and get rid of gambid? (That's what I recall you wanted to do at some point?)

  • Oh, Ok. We just wanted to add 'Clean Media' to the 'Prebid.js Bidding Partners' table.
  • Regarding to 'gambid', we will remove 'gambid' from the 'Prebid.js Bidding Partners' table in the next PR, but we'll keep it as an alias for backward compatibility, until it would be safe to remove it entirely.
    Thanks.

@sa1omon sa1omon closed this Feb 4, 2019
@sa1omon sa1omon deleted the add_cleanmedia_to_partners_branch branch February 4, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants