Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce video branch #3478

Merged
merged 10 commits into from
Jan 31, 2019
Merged

Conversation

sa1omon
Copy link
Contributor

@sa1omon sa1omon commented Jan 24, 2019

Type of change

  • Feature

Description of change

  • Added additional unit tests

  • Added an option to get bids of a specific media type (video, banner) when added to a multi-format bids

Example :

{
  bidder: 'gamoshi',
  params: {
    // ...
    favoredMediaType:'video'
  }
}
  • Please refer also to: Related PR in prebid.github.io

},
'device': {
'ua': navigator.userAgent
},
'imp': [],
'ext': {}
};
if (bidderRequest && bidderRequest.gdprConsent) {

if (bidderRequest.gdprConsent) {
Copy link
Collaborator

@robertrmartinez robertrmartinez Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa1omon

If a pub enables the consent module, but for some reason the consent information cannot be found,
then prebid passes an object like so to the bidders:

{
   gdprConsent: {
      consentString: undefined
      gdprApplies: undefined
      vendorData: undefined
  }
}

which in this scenario would end up sending an empty object to your exchange like so

{
   ... 
   ext: {
      gdpConsent: {}
   }
}

Looks like your ad server handles it just fine but wanted to make it known!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the insight, we will update the code in the next PR.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks, test coverage increased by 8% so we really appreciate it!

// favoredMediaType: 'video',
}
}]
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the expanded markdown information!

@robertrmartinez robertrmartinez merged commit e93d17d into prebid:master Jan 31, 2019
@sa1omon sa1omon deleted the enforce_video_branch branch February 4, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants