-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce video branch #3478
Enforce video branch #3478
Conversation
Sync upstream
}, | ||
'device': { | ||
'ua': navigator.userAgent | ||
}, | ||
'imp': [], | ||
'ext': {} | ||
}; | ||
if (bidderRequest && bidderRequest.gdprConsent) { | ||
|
||
if (bidderRequest.gdprConsent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a pub enables the consent module, but for some reason the consent information cannot be found,
then prebid passes an object like so to the bidders:
{
gdprConsent: {
consentString: undefined
gdprApplies: undefined
vendorData: undefined
}
}
which in this scenario would end up sending an empty object to your exchange like so
{
...
ext: {
gdpConsent: {}
}
}
Looks like your ad server handles it just fine but wanted to make it known!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the insight, we will update the code in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, test coverage increased by 8% so we really appreciate it!
// favoredMediaType: 'video', | ||
} | ||
}] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the expanded markdown information!
Type of change
Description of change
Added additional unit tests
Added an option to get bids of a specific media type (video, banner) when added to a multi-format bids
Example :