Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextMillennium Bid Adapter: Add ortb and element offsets #8671

Merged
merged 12 commits into from
Jul 13, 2022

Conversation

JacobKlein26
Copy link
Contributor

@JacobKlein26 JacobKlein26 commented Jul 11, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added more information to the bid request (bid.ortb2 / Ad Element.getBoundingClientRect)

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Jul 11, 2022

@JacobKlein26 pulling in recent prs should fix the CircleCi issue 👍 Can you also please add unit testing for this pr?

JacobKlein26 and others added 9 commits July 12, 2022 11:21
….ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>
…larify which CPM is being compared with which floor (prebid#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message
…test. (prebid#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.
@JacobKlein26
Copy link
Contributor Author

@ChrisHuie Thank you!
I updated and added 2 tests, please confirm if it's good now.

Thanks :)

@ChrisHuie ChrisHuie self-assigned this Jul 13, 2022
@ChrisHuie ChrisHuie merged commit 0be4560 into prebid:master Jul 13, 2022
@mifanich mifanich deleted the get-element-clientRect branch July 14, 2022 13:19
@JacobKlein26 JacobKlein26 restored the get-element-clientRect branch July 20, 2022 18:34
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* ortb2 and el offsets

* return empty object

* ortb2 and el offsets

* IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>

* PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message

* Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.

* return empty object

* fix ortb location (not in ext)

* add unit testing

Co-authored-by: shahinrahbariasl <[email protected]>
Co-authored-by: shahin.rahbariasl <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Keisuke Kakinuma <[email protected]>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
* ortb2 and el offsets

* return empty object

* ortb2 and el offsets

* IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>

* PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (prebid#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message

* Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (prebid#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.

* return empty object

* fix ortb location (not in ext)

* add unit testing

Co-authored-by: shahinrahbariasl <[email protected]>
Co-authored-by: shahin.rahbariasl <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Keisuke Kakinuma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants