Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) #8641

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

shahinrahbariasl
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add support for IX Bid Adapter to start reading impression transactionId (imp[].ext.tid) from ORTB object and send it to Exchange.

Other information

@shahinrahbariasl shahinrahbariasl marked this pull request as ready for review July 6, 2022 15:13
@ChrisHuie ChrisHuie self-requested a review July 7, 2022 15:25
@ChrisHuie ChrisHuie self-assigned this Jul 7, 2022
@ChrisHuie ChrisHuie merged commit be0e69b into prebid:master Jul 8, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Jul 12, 2022
….ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
….ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>
ChrisHuie pushed a commit that referenced this pull request Jul 13, 2022
* ortb2 and el offsets

* return empty object

* ortb2 and el offsets

* IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>

* PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message

* Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.

* return empty object

* fix ortb location (not in ext)

* add unit testing

Co-authored-by: shahinrahbariasl <[email protected]>
Co-authored-by: shahin.rahbariasl <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Keisuke Kakinuma <[email protected]>
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
….ext.tid) (#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* ortb2 and el offsets

* return empty object

* ortb2 and el offsets

* IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>

* PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message

* Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.

* return empty object

* fix ortb location (not in ext)

* add unit testing

Co-authored-by: shahinrahbariasl <[email protected]>
Co-authored-by: shahin.rahbariasl <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Keisuke Kakinuma <[email protected]>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
….ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
* ortb2 and el offsets

* return empty object

* ortb2 and el offsets

* IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (prebid#8641)

* IX Bid Adapter: add imp ext tid support

* fix tid level in imp ext object

Co-authored-by: shahin.rahbariasl <[email protected]>

* PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (prebid#8655)

* Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor

* Use full precision in log message

* Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (prebid#8642)

* update Adgeneration to add Criteo system and ID5 systems.

* Change method name.

* Correction_of_code_and_test_specs.

* Adding adgext_id5_id_link_type parameter to ID5 object.

* return empty object

* fix ortb location (not in ext)

* add unit testing

Co-authored-by: shahinrahbariasl <[email protected]>
Co-authored-by: shahin.rahbariasl <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Keisuke Kakinuma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants