Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartico Bid Adapter: Add meta fields to interpreted response object #7203

Merged
merged 17 commits into from
Jul 22, 2021
Merged

Smartico Bid Adapter: Add meta fields to interpreted response object #7203

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
02aeae0
Adding smartico adapter
Mar 26, 2021
65a324c
bug #6486 fix, added maintainer email
Mar 31, 2021
d36685c
bug #6486 fix, modified test parameters
Mar 31, 2021
6587e67
bug #6486 fix, modified test parameters #2
Mar 31, 2021
b3d342b
#6486 applied review related updates & fixes
Apr 15, 2021
93f0979
#6486 applied review related updates & fixes #2
Apr 20, 2021
ec597fc
#6486 applied review related updates & fixes #3
Apr 21, 2021
8ea0faa
Merge branch 'prebid:master' into master
cs83 Jun 25, 2021
ad3cd13
samrtico adapter bug fix
Jun 25, 2021
12b80d7
smartico adapter unit test update after bug fixing
Jun 25, 2021
04dc329
smartico adapter bug fix #2
Jun 28, 2021
cdd3cbf
smartico adapter bug fix #3
Jun 28, 2021
a80785c
fix linting errors
ChrisHuie Jul 12, 2021
0eb9dd0
Merge branch 'prebid:master' into master
cs83 Jul 14, 2021
437bf57
update for version 5.0: meta.advertiserDomains is added
Jul 15, 2021
7a4a8b0
update for version 5.0: meta.advertiserDomains is added (unit test) …
Jul 21, 2021
9c28d91
Update smarticoBidAdapter_spec.js
patmmccann Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/smarticoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ export const spec = {
netRevenue: !!ad.netRevenue,
currency: ad.currency,
ttl: ad.ttl,
ad: html
ad: html,
meta: {
advertiserDomains: ad.domains,
advertiserName: ad.title
}
}
bidResponses.push(bidObject);
}
Expand Down
13 changes: 11 additions & 2 deletions test/spec/modules/smarticoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ describe('smarticoBidAdapter', function () {
ttl: 30,
bannerFormatWidth: 300,
bannerFormatHeight: 250,
bannerFormatAlias: 'medium_rectangle'
bannerFormatAlias: 'medium_rectangle',
domains: ['www.advertiser.com'],
title: 'Advertiser'
}]
};
let expectedResponse = [{
Expand All @@ -93,7 +95,11 @@ describe('smarticoBidAdapter', function () {
currency: 'EUR',
netRevenue: false, // gross
ttl: 30,
ad: '<script id="smartico-widget-testPlacementId-0" async defer type="text/javascript" src="https://trmads.eu/get?token=FNVzUGZn9ebpIOoheh3kEJ2GQ6H6IyMH39sHXaya&auction-id=5kaj89l8-3456-2s56-c455-4g6h78jsdfgf&from-auction-buffer=1&own_session=1&ad=987654&scriptid=smartico-widget-testPlacementId-0&banner-format=medium_rectangle"><\/script>'}];
ad: '<script id="smartico-widget-testPlacementId-0" async defer type="text/javascript" src="https://trmads.eu/get?token=FNVzUGZn9ebpIOoheh3kEJ2GQ6H6IyMH39sHXaya&auction-id=5kaj89l8-3456-2s56-c455-4g6h78jsdfgf&from-auction-buffer=1&own_session=1&ad=987654&scriptid=smartico-widget-testPlacementId-0&banner-format=medium_rectangle"><\/script>',
meta: {
advertiserDomains: ['www.advertiser.com'],
advertiserName: 'Advertiser'
}}];
let result = spec.interpretResponse(serverResponse, bidRequest);
it('should contain correct creativeId', function () {
expect(result[0].creativeId).to.equal(expectedResponse[0].creativeId)
Expand Down Expand Up @@ -122,5 +128,8 @@ describe('smarticoBidAdapter', function () {
it('should contain correct ad content', function () {
expect(result[0].ad).to.equal(expectedResponse[0].ad)
});
it('should contain correct meta content', function () {
expect(result[0].meta).to.equal(expectedResponse[0].meta)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deep.equal

});
});
});