Smartico Bid Adapter: Add meta fields to interpreted response object #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jul 21, 2021
patmmccann
requested changes
Jul 21, 2021
| @@ -122,5 +128,8 @@ describe('smarticoBidAdapter', function () { | |||
| it('should contain correct ad content', function () { | |||
| expect(result[0].ad).to.equal(expectedResponse[0].ad) | |||
| }); | |||
| it('should contain correct meta content', function () { | |||
| expect(result[0].meta).to.equal(expectedResponse[0].meta) | |||
patmmccann
changed the title
patmmccann
changed the title
ChrisHuie
approved these changes
Jul 22, 2021
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
…rebid#7203) * Adding smartico adapter * bug prebid#6486 fix, added maintainer email * bug prebid#6486 fix, modified test parameters * bug prebid#6486 fix, modified test parameters #2 * prebid#6486 applied review related updates & fixes * prebid#6486 applied review related updates & fixes #2 * prebid#6486 applied review related updates & fixes #3 * samrtico adapter bug fix * smartico adapter unit test update after bug fixing * smartico adapter bug fix #2 * smartico adapter bug fix #3 * fix linting errors * update for version 5.0: meta.advertiserDomains is added * update for version 5.0: meta.advertiserDomains is added (unit test) update * Update smarticoBidAdapter_spec.js Co-authored-by: Dmitri <[email protected]> Co-authored-by: Chris Huie <[email protected]> Co-authored-by: Patrick McCann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information