Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartico Bid Adapter: Add meta fields to interpreted response object #7203

Merged
merged 17 commits into from
Jul 22, 2021

Conversation

cs83
Copy link
Contributor

@cs83 cs83 commented Jul 21, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie self-requested a review July 21, 2021 17:02
@ChrisHuie ChrisHuie self-assigned this Jul 21, 2021
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need to change to .deep.equal

@@ -122,5 +128,8 @@ describe('smarticoBidAdapter', function () {
it('should contain correct ad content', function () {
expect(result[0].ad).to.equal(expectedResponse[0].ad)
});
it('should contain correct meta content', function () {
expect(result[0].meta).to.equal(expectedResponse[0].meta)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deep.equal

@patmmccann patmmccann changed the title Change for version 5.0, advertisersDomains property is added Smartico Bid Adapter: Add meta fields Jul 21, 2021
@patmmccann patmmccann changed the title Smartico Bid Adapter: Add meta fields Smartico Bid Adapter: Add meta fields to interpreted response object Jul 21, 2021
@ChrisHuie ChrisHuie merged commit b4c2552 into prebid:master Jul 22, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
…rebid#7203)

* Adding smartico adapter

* bug prebid#6486 fix, added maintainer email

* bug prebid#6486 fix, modified test parameters

* bug prebid#6486 fix, modified test parameters #2

* prebid#6486 applied review related updates & fixes

* prebid#6486 applied review related updates & fixes #2

* prebid#6486 applied review related updates & fixes #3

* samrtico adapter bug fix

* smartico adapter unit test update after bug fixing

* smartico adapter bug fix #2

* smartico adapter bug fix #3

* fix linting errors

* update for version 5.0: meta.advertiserDomains is added

* update for version 5.0: meta.advertiserDomains is added (unit test) update

* Update smarticoBidAdapter_spec.js

Co-authored-by: Dmitri <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants