-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lifestreet adapter 3.0 #4927
Lifestreet adapter 3.0 #4927
Conversation
Test coverage is below 80%, please add more unit tests. |
I still see that github reports Other than that, I tested (with your test unit) and req/resp look good, I don't see many changes in comparison to the 2.x version. So if you can fix those small remarks I can approve your changes. |
hi Alexa! all done, it was a pleasure to work with you! |
* 'master' of https://github.com/prebid/Prebid.js: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
* master: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
* Added adapter without tests * Added readme * Added tests and CCPA support * Cleaned code, fixed tests * reverted examples * Added more tests + CR fixes * Fixed example in lifestreet readme, reverted integration example page * restored permission for page example
* Added adapter without tests * Added readme * Added tests and CCPA support * Cleaned code, fixed tests * reverted examples * Added more tests + CR fixes * Fixed example in lifestreet readme, reverted integration example page * restored permission for page example
Type of change
Description of change
Lifestreet adapter for Prebid 3.0 + CCPA support
We had version for 2.0, but previous version has been deleted from main repo, so I not sure which label is correct. Apologize for this, hope have both is fine.
email of the adapter’s maintainer: [email protected]
PR link: prebid/prebid.github.io#1835
Other information