-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submitting Clicktripz bid adapter #4929
Conversation
- adapter - description - test
Hi @bx2, I see this PR has a |
I will try to finish the review today. In the meantime, the "needs-docs" label means that you are still to submit a MR with your bidder documentation. Take a look at https://prebid.org/dev-docs/bidder-adaptor.html at the very bottom:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you patience. You will find my comments below. Additionally, please:
- Fix the linting issue in the code:
Prebid.js/test/spec/modules/clicktripzBidAdapter_spec.js
2:20 error Missing file extension "js" for "modules/clicktripzBidAdapter" import/extension
- Do not modify our
packages.lock
with this MR. If for some reason you think this file should be updated, please submit it as a separate MR as changes you added there do not influence operations of the adapter.
Hi @bx2, I have that MR here prebid/prebid.github.io#1836 |
- imports _each from ../src/utils.js - replace use of .forEach with _each - log entire error, removes loop - splits size once - fix typo in documentation file - fix linter erro in test file
@apmitchell thanks for you patience. I reviewed and accepted the changes you submitted. They will be available in the next release of Prebid. You may open a PR in the headerbid-expert repository to have your adapter recognized by the Headerbid Expert extension. The PR should be to the bidder patterns file, adding an entry with your adapter's name and the url the adapter uses to send and receive bid responses. |
* 'master' of https://github.com/prebid/Prebid.js: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
* master: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
Clicktripz bid adapter - adapter - description - test
Type of change
Description of change
Submitting Clicktripz bidder adapter for acceptance into the prebid.js repo.
Includes:
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information