AppNexus Bid Adapter: Add support for 'video' in custom Native fields #12345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be used in native creatives directly
|
related #10321 |
|
@JaroVDH do you have a test page with a currently working example of the native video to validate against these changes? |
|
@jsnellbaker Do you mean for the backwards compatible video in the bid response? |
jsnellbaker
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Copy 'video' over to custom native fields so it can be used in native creatives directly.
It already exists in the base native object, but that's not accessible as asset as it's not a default field in Prebid.
I've also kept the 'video' field in the base object for backwards compatibility, in case people are reading it from the bid directly already.
Other information
This PR will also be forwarded to the Xandr teams for their approval.