Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNexus Bid Adapter: Add support for custom Native fields #12272

Merged

Conversation

JaroVDH
Copy link
Contributor

@JaroVDH JaroVDH commented Sep 25, 2024

Type of change

  • Updated bidder adapter

Description of change

Includes AppNexus/Xandr's custom Native fields in the bid response's ext field.

Other information

This PR will also be forwarded to the Xandr teams for their approval.

@JaroVDH
Copy link
Contributor Author

JaroVDH commented Sep 25, 2024

Small note/question: I used the spread syntax (...) in the tests.
Prebid.js supports IE 11, which doesn't support that.
I don't think it's an issue as it's part of the tests, and those run on node 12+.
If it is an issue, I'll quickly change it.

@JaroVDH
Copy link
Contributor Author

JaroVDH commented Sep 25, 2024

Looks like the e2etest failed.
Locally, the same 6 tests failed before and after my changes, so I didn't expect a failure there.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting these changes together. LGTM

@jsnellbaker jsnellbaker merged commit d253486 into prebid:master Sep 27, 2024
5 of 6 checks passed
@JaroVDH JaroVDH deleted the appnexusadapter-custom-native-fields branch October 21, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants