Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nobid Analytics Adapter : import logMessage #11833

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

patmmccann
Copy link
Collaborator

Fixes #11668

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@patmmccann patmmccann changed the title Update nobidAnalyticsAdapter.js nobidAnalyticsAdapter.js: import logMessage Jun 19, 2024
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann patmmccann requested a review from ChrisHuie June 19, 2024 18:18
@ChrisHuie ChrisHuie changed the title nobidAnalyticsAdapter.js: import logMessage nobid Analytics Adapter : import logMessage Jun 20, 2024
@ChrisHuie ChrisHuie merged commit e132450 into master Jun 20, 2024
4 of 5 checks passed
@ChrisHuie ChrisHuie deleted the patmmccann-patch-13 branch June 20, 2024 10:34
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* Update nobidAnalyticsAdapter.js

Fixes prebid#11668

* Update uid2IdSystem_shared.js

* Update uid2IdSystem.js

* Update nobidAnalyticsAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nobid Analytics: use our methods
2 participants