Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nobid Analytics: use our methods #11668

Closed
patmmccann opened this issue Jun 3, 2024 · 0 comments · Fixed by #11833
Closed

Nobid Analytics: use our methods #11668

patmmccann opened this issue Jun 3, 2024 · 0 comments · Fixed by #11833
Labels
10.0 API Change

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 3, 2024 •
edited
Loading

Please fix

Prebid.js/modules/nobidAnalyticsAdapter.js

Line 30 in eb5d18f

console.log(`%cNoBid Analytics ${VERSION}`, 'padding: 2px 8px 2px 8px; background-color:#f50057; color: white', msg);
to use appropriate logging methods

cc redaguermas
@patmmccann patmmccann moved this from Triage to Tracking in Prebid.js Tactical Issues table Jun 17, 2024
patmmccann added a commit that referenced this issue Jun 19, 2024
@patmmccann
Update nobidAnalyticsAdapter.js
ddad24a 
Fixes #11668
@patmmccann patmmccann mentioned this issue Jun 19, 2024
Merged
10 tasks
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this issue Jul 18, 2024
@patmmccann @DecayConstant
nobid Analytics Adapter : import logMessage (prebid#11833)
5646a6c 
* Update nobidAnalyticsAdapter.js

Fixes prebid#11668

* Update uid2IdSystem_shared.js

* Update uid2IdSystem.js

* Update nobidAnalyticsAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.0 API Change
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nobid Analytics Adapter : import logMessage prebid/Prebid.js
1 participant
@patmmccann