add lodash as dependency #1174
Merged
add lodash as dependency #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AOL is only using lodash in build, then? If so then great! If in runtime they should not most likely. A thought for 1.0 is to use lodash path imports to get concise functions in the runtime as well. |
|
Yeah, just the build; which I'm fine with because in my modules 1.0 pull-request I'll also be using lodash in some gulp functions. I agree on using path imports for runtime inclusion of lodash if we decide to use it there at all. |
mkendall07
approved these changes
May 3, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
May 4, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (21 commits) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115) Prebid Server to Server (prebid#1165) Pubgears Header Bidding Adapter (prebid#953) remove old adloader#trackPixel (prebid#1159) added audit beacon to detect misuse of this bidder. Detects auctions… (prebid#1134) Bidfluence CDN endpoint URL update (prebid#1163) AdSupply adapter (prebid#1162) Sonobi Adapter - Enable size overrides (prebid#1141) Added an editorconfig file to match jshint and jssrc files. (prebid#1147) force cpm to be a number (prebid#1161) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 25, 2017
…21.0 to aolgithub-master * commit '4d573b42c5fbbabf23fed48fa042b75a72dd16b2': (31 commits) Added prebidServer in aolPartnersIds.json. Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.23.1 Release Add trafficSourceCode + test (prebid#1184) Clear cookie sync to prevent multiple calls (prebid#1181) change s2s adapter to filter out units with empty sizes array (prebid#1179) Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj (prebid#1108) check array length when mapping sizes (prebid#1180) Bugfix/encoding url (prebid#1178) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
AOL is using lodash but not declaring it as a dependency. Lodash is already a dependency of another dependency so the build still works fine with npm 3 but breaks in npm 2 which doesn't use a flat dependency tree. I've already fixed this once in #1055 here: https://github.com/prebid/Prebid.js/pull/1055/files?diff=unified#diff-baeaea56bb14bac6f8ad04712f1b02bcL2 but they undid my changes and added it back in their latest pulll request #1115 here: https://github.com/prebid/Prebid.js/pull/1115/files?diff=unified#diff-baeaea56bb14bac6f8ad04712f1b02bcR2
Since it's already a dependency of a dependency there's really no harm in just adding it as a first-class dependency, so that's what this pull-request is.