Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yieldbot adapter - multiple requestBids per pageview #1146

Merged
merged 1 commit into from
May 2, 2017
Merged

Yieldbot adapter - multiple requestBids per pageview #1146

merged 1 commit into from
May 2, 2017

Conversation

elljoh
Copy link
Contributor

@elljoh elljoh commented Apr 20, 2017

Type of change

  • Feature

Description of change

In the Yieldbot adapter, adds feature to allow requests for further Yieldbot bids after the first call to requestBids().

Other information

Fixes #481

@protonate protonate self-assigned this Apr 28, 2017
@protonate protonate self-requested a review April 28, 2017 16:55
@protonate protonate added this to the Prebid 0.23.0 milestone May 2, 2017
protonate
protonate approved these changes May 2, 2017
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protonate protonate requested a review from matthewlane May 2, 2017 20:35
@matthewlane matthewlane merged commit 0956c74 into prebid:master May 2, 2017
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request May 4, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
482c0ed 
…built

* 'master' of https://github.com/prebid/Prebid.js: (21 commits)
  add lodash as dependency (prebid#1174)
  fix size mapping for s2s (prebid#1175)
  Improve footer styling (prebid#1171)
  Bugfix: internal bids requested overwritten (prebid#1173)
  pre-release version bump
  Prebid 0.23.0 Release
  Yieldbot adapter - multiple requestBids per pageview (prebid#1146)
  Widespace adapter validate size fix (prebid#1140)
  Audience Network: bid when at least one valid slot size (prebid#1148)
  Quantcast adaptor (prebid#1063)
  AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115)
  Prebid Server to Server (prebid#1165)
  Pubgears Header Bidding Adapter (prebid#953)
  remove old adloader#trackPixel (prebid#1159)
  added audit beacon to detect misuse of this bidder.  Detects auctions… (prebid#1134)
  Bidfluence CDN endpoint URL update (prebid#1163)
  AdSupply adapter (prebid#1162)
  Sonobi Adapter - Enable size overrides (prebid#1141)
  Added an editorconfig file to match jshint and jssrc files. (prebid#1147)
  force cpm to be a number (prebid#1161)
  ...
@aneuway2
Copy link
Contributor

@elljoh if I understand correctly, does this PR allow more than 1 size to be passing to the Yieldbot adaptor to receive bids, or if this for something else?

Thanks!

@elljoh
Copy link
Contributor Author

elljoh commented May 22, 2017

@aneuway2
The Yieldbot adapter has always supported requesting multiple AdUnit and/or sizes of AdUnit creatives in a request: the nature of this PR is slightly different.

This PR is related to calls to refresh bids on the same page view browsing context i.e. any bid request subsequent to the initial requestBids() call.

Prior to this PR, a "refresh" call to requestBids() after the initial request for bids, that included Prebid config for the Yieldbot adapter, would not result in a request for bids from Yieldbot.

  • Reason being, that the equivalent of a "refresh" call needed to be made in the Yieldbot adapter. If not, the underlying adapter library would exit early.

With this change, calls to refreshBids() where the Yieldbot adapter is configured will result in requests for bids being made.

@aneuway2
Copy link
Contributor

Ah gotcha. Thanks for the context! Very helpful!

vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 25, 2017
@vzhukovsky
Merge pull request prebid#97 in AOLP_ADS_JS/prebid.js from release/1.…
51f0f73 
…21.0 to aolgithub-master

* commit '4d573b42c5fbbabf23fed48fa042b75a72dd16b2': (31 commits)
  Added prebidServer in aolPartnersIds.json.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.23.1 Release
  Add trafficSourceCode + test (prebid#1184)
  Clear cookie sync to prevent multiple calls (prebid#1181)
  change s2s adapter to filter out units with empty sizes array (prebid#1179)
  Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj (prebid#1108)
  check array length when mapping sizes (prebid#1180)
  Bugfix/encoding url (prebid#1178)
  add lodash as dependency (prebid#1174)
  fix size mapping for s2s (prebid#1175)
  Improve footer styling (prebid#1171)
  Bugfix: internal bids requested overwritten (prebid#1173)
  pre-release version bump
  Prebid 0.23.0 Release
  Yieldbot adapter - multiple requestBids per pageview (prebid#1146)
  Widespace adapter validate size fix (prebid#1140)
  Audience Network: bid when at least one valid slot size (prebid#1148)
  Quantcast adaptor (prebid#1063)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

@protonate protonate protonate approved these changes

Assignees

@protonate protonate

Labels
needs review
Projects
None yet
Milestone
Prebid 0.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@elljoh @aneuway2 @matthewlane @protonate @mkendall07