Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact-render-to-string invokes optins,unmount but has no _dom #198

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

JoviDeCroock
Copy link
Member

fixes #197

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 047cb9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 047cb9c
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/632cb9be8151120008930e7b
😎 Deploy Preview https://deploy-preview-198--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

Size Change: +250 B (0%)

Total Size: 67.5 kB

Filename Size Change
docs/dist/assets/index.********.js 1.08 kB +243 B (+29%) 🚨
docs/dist/assets/signals.module.********.js 1.96 kB +2 B (0%)
docs/dist/basic-********.js 244 B -1 B (0%)
docs/dist/demos-********.js 3.35 kB -2 B (0%)
packages/preact/dist/signals.js 1.19 kB +5 B (0%)
packages/preact/dist/signals.mjs 1.15 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 45.8 kB
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/signals-core.module.********.js 1.34 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 237 B
packages/core/dist/signals-core.js 1.39 kB
packages/core/dist/signals-core.mjs 1.42 kB
packages/react/dist/signals.js 833 B
packages/react/dist/signals.mjs 810 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmounting throws in SSR
2 participants