Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmounting throws in SSR #197

Closed
matthewp opened this issue Sep 22, 2022 · 3 comments · Fixed by #198
Closed

Unmounting throws in SSR #197

matthewp opened this issue Sep 22, 2022 · 3 comments · Fixed by #198

Comments

@matthewp
Copy link

When used with preact-render-to-string and unmounting a vnode it throws here:

const updaters = dom._updaters;
because __e is null.

Noticed that another hook checks to see if it exists:

if (typeof vnode.type === "string" && (dom = vnode.__e as Element)) {

So I'm guessing the problem is just with the unmount hook?

@marvinhagemeister
Copy link
Member

@matthewp Thanks for reporting this issue. We'll cut a new release in a bit.

@marvinhagemeister
Copy link
Member

@matthewp Alright, fix is published as @preact/signals v1.1.1

@matthewp
Copy link
Author

Thank you @marvinhagemeister and @JoviDeCroock !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants