Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for serializing bigints. #454

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Adds support for serializing bigints. #454

merged 1 commit into from
Feb 28, 2023

Commits on Feb 5, 2023

  1. Adds support for serializing bigints. 

    I went with serializing bigints as an object with a type and value, but I'm open to other ideas for how to serialize them so they are JSON compatible.

I don't know why I needed to change the type of `setInCopy`, but the original type definition appears to have been incorrect.

I largely don't understand what most of the properties in `parseProps` are for, so I just tried to copy other thinsg in a way that seemed reasonable.
In particular, `editable` I set to `!forceReadonly` but this was really just a guess on my part.

I made a few changes to improve the type strictness of `JSONValue`.
If these strictness increases are considered undesirable then everything except the addition of `JSONBigint` can be removed without causing problems.
    @MicahZoltu
    MicahZoltu committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    fe2a6ac View commit details
    Browse the repository at this point in the history