Adds support for serializing bigints. #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with serializing bigints as an object with a type and value, but I'm open to other ideas for how to serialize them so they are JSON compatible.
I don't know why I needed to change the type of
setInCopy
, but the original type definition appears to have been incorrect.I largely don't understand what most of the properties in
parseProps
are for, so I just tried to copy other parsers in a way that seemed reasonable. In particular,editable
I set to!forceReadonly
but this was really just a guess on my part.I made a few changes to improve the type strictness of
JSONValue
. If these strictness increases are considered undesirable then everything except the addition ofJSONBigint
can be removed without causing problems.Fixes #453