Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sidecar feature to zookeeper-operator #344

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Adding sidecar feature to zookeeper-operator #344

merged 4 commits into from
Jun 8, 2021

Conversation

adapured
Copy link
Contributor

@adapured adapured commented Jun 8, 2021

Change log description

Adding sidecar features to zookeeper-operator

Purpose of the change

Fixes #345
Integrate. and enable the Sidecars with zookeeper-operator

What the code does

Enable and. configure volumes and environment variables required for sidecars.

How to verify it

1.Helm lint.
2.Update the .Values with Any Sidecar containers.
3.By adding required additional volumes and Environment variables.
4.helm template.

@adapured
Copy link
Contributor Author

adapured commented Jun 8, 2021

@anishakj forked from pravega/zookeeper-operator repo and fixed conflicts. Closed the old PR(#341)

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #344 (2cf0ed2) into master (b087a7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files          11       11           
  Lines        1376     1376           
=======================================
  Hits         1163     1163           
  Misses        140      140           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d5e78...2cf0ed2. Read the comment docs.

@anishakj anishakj requested a review from SrishT June 8, 2021 03:51
Copy link
Contributor

@SrishT SrishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit c0136b1 into pravega:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding sidecar to zookeeper operator
4 participants