Adding sidecar feature to ZookeeperOperator #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adapured could you please resolve conflict? |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 11 11
Lines 1376 1376
=======================================
Hits 1163 1163
Misses 140 140
Partials 73 73 Continue to review full report at Codecov.
|
It looks like your branch is not forked from |
Resolved the conflicts. |
|
Fork needs to be fixed. Hence closing this PR and opening new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Adding sidecar features to zookeeper-operator
Purpose of the change
Integrate. and enable the Sidecars with zookeeper-operator
What the code does
Enable and. configure volumes and environment variables required for sidecars.
How to verify it
1.Helm lint.
2.Update the .Values with Any Sidecar containers.
3.By adding required additional volumes and Environment variables.
4.helm template.