Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 250: Not specifying a default storageclass #253

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Oct 6, 2020

Signed-off-by: SrishT [email protected]

Change log description

Does not specify any default value for storageclass which allows the default storageclass for the given environment to be picked instead of having to hard-code it.

Purpose of the change

Fixes #250

How to verify it

Install the zookeeper charts which do not specify any value for the storageclass. The following command shows that the default storageclass for the environment will be automatically picked.

$ kubectl get storageclass
NAME                 PROVISIONER                                       AGE
nfs                  cluster.local/nfs-server-provisioner-1599805455   25d
standard (default)   kubernetes.io/vsphere-volume                      25d

$ kubectl get pvc
NAME                    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
data-zookeeper-0        Bound    pvc-6120fb84-919b-402b-812b-834b79edc649   20Gi       RWO            standard       69m
data-zookeeper-1        Bound    pvc-0de5bc53-e6a5-40ba-8b8e-d7d65a1bcc85   20Gi       RWO            standard       68m
data-zookeeper-2        Bound    pvc-0b6d6218-7c78-4496-b711-f27d006c88aa   20Gi       RWO            standard       68m

@SrishT SrishT requested review from anishakj and Ranganaths8 October 6, 2020 11:31
@codecov-commenter
Copy link

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          11       11           
  Lines        1118     1118           
=======================================
  Hits          932      932           
  Misses        125      125           
  Partials       61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f0f90...2a898d3. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit ece4987 into master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standard should not be set as the default storageclass
3 participants