Skip to content

Commit

Permalink
Issue 250: Not specifying a default storageclass (#253)
Browse files Browse the repository at this point in the history
Signed-off-by: SrishT <[email protected]>

Co-authored-by: SrishT <[email protected]>
  • Loading branch information
SrishT and SrishT authored Oct 7, 2020
1 parent 42f0f90 commit ece4987
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/zookeeper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ The following table lists the configurable parameters of the zookeeper chart and
| `config.quorumListenOnAllIPs` | Whether Zookeeper server will listen for connections from its peers on all available IP addresses | `false` |
| `storageType` | Type of storage that can be used it can take either ephemeral or persistence as value | `persistence` |
| `persistence.reclaimPolicy` | Reclaim policy for persistent volumes | `Delete` |
| `persistence.storageClassName` | Storage class for persistent volumes | `standard` |
| `persistence.storageClassName` | Storage class for persistent volumes | `` |
| `persistence.volumeSize` | Size of the volume requested for persistent volumes | `20Gi` |
| `ephemeral.emptydirvolumesource.medium` | What type of storage medium should back the directory. | `""` |
| `ephemeral.emptydirvolumesource.sizeLimit` | Total amount of local storage required for the EmptyDir volume. | `20Gi` |
Expand Down
6 changes: 6 additions & 0 deletions charts/zookeeper/templates/zookeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,15 @@ spec:
{{- else }}
persistence:
reclaimPolicy: {{ .Values.persistence.reclaimPolicy }}
{{- if or .Values.persistence.storageClassName .Values.persistence.volumeSize }}
spec:
{{- if .Values.persistence.storageClassName }}
storageClassName: {{ .Values.persistence.storageClassName }}
{{- end }}
{{- if .Values.persistence.volumeSize }}
resources:
requests:
storage: {{ .Values.persistence.volumeSize }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/zookeeper/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ config: {}
storageType: persistence

persistence:
storageClassName: standard
storageClassName:
## specifying reclaim policy for PersistentVolumes
## accepted values - Delete / Retain
reclaimPolicy: Delete
Expand Down

0 comments on commit ece4987

Please sign in to comment.