Add difficulty skill for Flashlight mod #14217
Conversation
frenzibyte
changed the title
|
Values look fine to me now |
|
This seems to be generating a few inifinite values: |
|
Nevermind, the above look to be issues with data.ppy.sh beatmap dumps: |
|
Top 2000 differences (as of 2020/09): https://docs.google.com/spreadsheets/d/1oHefM278mEs9rXgunspPx2Ty_knzQn25fVd1Ox4-bSU/edit?usp=sharing Looks reasonable to me. |
|
Which plays are these? I have a feeling the biggest differences occur in the lower pp ranges (for example Index's play on paraparamax +hdfl which goes up by about 180pp) |
|
Right, that's from the _top dataset from https://data.ppy.sh/ (top 10000 users). |
|
@MBmasher what's the go on this, holding back until the difference in score |
|
With this system, I'm not sure if it's possible to account for that without harshly nerfing the values of most other maps. I think it's okay to leave it as it is now, especially considering this is a pretty rare case and even so the difficulty of such plays is still pretty high edit: to be clear, the map that the score |
|
I have some issues with this PR such as not accounting for FL radius changing with combo, hidden, or big circles overlapping the visible area more than small circles. The strain scaling for each object is also done in an unusual way, but it works. The concerns are minor enough and the values are already balanced so we agreed with @MBmasher to keep the PR as it is. It's definitely an improvement from live, I don't see a reason for not approving. |
| @@ -9,6 +9,7 @@ public class OsuDifficultyAttributes : DifficultyAttributes | |||
| { | |||
| public double AimStrain { get; set; } | |||
| public double SpeedStrain { get; set; } | |||
| public double FlashlightRating { get; set; } | |||
There was a problem hiding this comment.
Should we really be adding attributes based specifically on mod names? I don't know this seems like a really bad direction.
There was a problem hiding this comment.
What are you proposing? It's a special case so I think it's warranted?
There was a problem hiding this comment.
It could be VisualRating or ReadingStrain, something like that. It wouldn't make sense to keep adding ratings for each visual mod, as they all affect the same thing and they usually interact in different ways.
For example, the difference between nomod and HD is not the same as the difference between FL and FLHD.
These interactions should be accounted for when calculating the difficulty rating.
This is a proposal to implement a Flashlight skill to more accurately measure the difficulty of Flashlight plays. Currently the Flashlight bonus is just a multiplier based on object count onto aim pp and this is inaccurate for many reasons. Read more: Writeup link
Values can be checked at https://flashlight.stanr.info/