Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Add application/ld+json to posts and pages #244

Merged
merged 1 commit into from
Dec 28, 2018

Conversation

marcofranssen
Copy link
Contributor

This PR adds a new feature to the theme to include https://jsonld.com/blog-post/ to every blogpost and page.

@ppoffice
Copy link
Owner

@marcofranssen I saw you hard-coded author name in the script. Could you please replace it with <%= author %>? Also, I'm not sure if every post has post.update and post.title. Maybe we should wrap those two lines with if.

@marcofranssen marcofranssen force-pushed the feature/ld-plus-json-posts branch 2 times, most recently from 1cddbe6 to 091b129 Compare December 28, 2018 17:57
@marcofranssen
Copy link
Contributor Author

marcofranssen commented Dec 28, 2018

Updated the PR, one question though! How do I get rid of the whitelines when the if is evaluated false?

@ppoffice ppoffice merged commit 9e35147 into ppoffice:master Dec 28, 2018
@ppoffice
Copy link
Owner

@marcofranssen You probably can construct the JSON data as a whole and print it out. Or use some minifier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants