Skip to content

Commit

Permalink
Fixed DAG triggering with parameters
Browse files Browse the repository at this point in the history
There was a bad cherry-pick when merging apache#15057 that has not
been caught because of quarantined test.

Fixes: apache#16810
  • Loading branch information
potiuk committed Jul 5, 2021
1 parent a71f9d6 commit 82007dc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion airflow/www/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -1523,7 +1523,7 @@ def trigger(self, session=None):
if request_conf:
try:
run_conf = json.loads(request_conf)
if not isinstance(conf, dict):
if not isinstance(run_conf, dict):
flash("Invalid JSON configuration, must be a dict", "error")
return self.render_template(
'airflow/trigger.html', dag_id=dag_id, origin=origin, conf=request_conf
Expand Down
1 change: 0 additions & 1 deletion tests/www/views/test_views_trigger_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def test_trigger_dag_button(admin_client):
assert run.run_type == DagRunType.MANUAL


@pytest.mark.quarantined
def test_trigger_dag_conf(admin_client):
test_dag_id = "example_bash_operator"
conf_dict = {'string': 'Hello, World!'}
Expand Down

0 comments on commit 82007dc

Please sign in to comment.