Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airflow is not accepting configuration from Admin UI #16810

Closed
vikramcse opened this issue Jul 5, 2021 · 9 comments
Closed

airflow is not accepting configuration from Admin UI #16810

vikramcse opened this issue Jul 5, 2021 · 9 comments
Labels
kind:bug This is a clearly a bug priority:high High priority bug that should be patched quickly but does not require immediate new release
Milestone

Comments

@vikramcse
Copy link
Contributor

vikramcse commented Jul 5, 2021

Apache Airflow version: 2.1.1

Kubernetes version (if you are using kubernetes) (use kubectl version): NO

Environment: local (docker + ubuntu)

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release): Debian GNU/Linux 10 (buster)
  • Kernel (e.g. uname -a): linux

What happened:
airflow is not accepting configuration from Admin UI

when I submit a DAG configuration from UI, it is giving me error Invalid JSON configuration, must be a dict

image

the same workflow is working in airflow 2.1.0 version
I think this issue occurred in this PR #15057

What you expected to happen:
Airflow admin should accept the conf from UI and trigger the dag

How to reproduce it:
It can be reproduced for all cases, we have to put any valid JSON into the configuration window on a DAG

Willing to submit PR
YES

@vikramcse vikramcse added the kind:bug This is a clearly a bug label Jul 5, 2021
@potiuk
Copy link
Member

potiuk commented Jul 5, 2021

Can't use my PC at the moment but it does look awfully a lot like we need to release 2.1.2 with a fix if it is confirmed @ashb @kaxil @jhtimmins

@ashb
Copy link
Member

ashb commented Jul 5, 2021

Agreed, will confirm.

@potiuk potiuk added the priority:high High priority bug that should be patched quickly but does not require immediate new release label Jul 5, 2021
@potiuk
Copy link
Member

potiuk commented Jul 5, 2021

Got hold of my PC. Confirmed that it does not occur in main but it DOES occur in 2.1.1.

@kaxil kaxil added this to the Airflow 2.1.2 milestone Jul 5, 2021
@potiuk
Copy link
Member

potiuk commented Jul 5, 2021

I have a fix (conf-> run_conf) - likely bad cherry-pick. Looking at why it has not been caught by the test_harness (the tests for dag triggering seem to pass :(.

potiuk added a commit to potiuk/airflow that referenced this issue Jul 5, 2021
There was a bad cherry-pick when merging apache#15057 that has not
been caught because of quarantined test.

Fixes: apache#16810
@kaxil
Copy link
Member

kaxil commented Jul 5, 2021

Looks like we already had a fix: #16648

@potiuk
Copy link
Member

potiuk commented Jul 5, 2021

Yep. That's it. Also it has not been caught in the tests because the test was quarantined. Looks like we need to take a close look at the quarantined tests and fix them.

@kaxil
Copy link
Member

kaxil commented Jul 5, 2021

I have cherry-picked it to v2-1-stable and v2-1-test, we will cut a 2.1.2 release which should be available to the users by the end of this week.

Until then, please use the API or CLI to trigger dags.

@vikramcse
Copy link
Contributor Author

yes I will use the api till then
thanks @potiuk and @kaxil for checking this issue 👍

@ashb
Copy link
Member

ashb commented Jul 7, 2021

Closing this issue as the fix is merged and it will be released soon.

@ashb ashb closed this as completed Jul 7, 2021
potiuk added a commit to potiuk/airflow that referenced this issue Aug 1, 2021
This test caused missing failure that manifested in 2.1.1 in
the apache#16810
potiuk added a commit to potiuk/airflow that referenced this issue Aug 7, 2021
This test caused missing failure that manifested in 2.1.1 in
the apache#16810
potiuk added a commit that referenced this issue Aug 7, 2021
This test caused missing failure that manifested in 2.1.1 in
the #16810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug priority:high High priority bug that should be patched quickly but does not require immediate new release
Projects
None yet
Development

No branches or pull requests

4 participants