Fix(#182): correct types and type checks #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #182.
X-Ref: parcel-bundler/parcel#7906
PostHTML does supports
node.content
to be either astring
or astring[]
when stringify a PostHTML AST Tree into HTML, while PostHTML parser will only emitnode.content
as an array of string. So the new htmlnano module syntax (#128) just take it for granted thatnode.content
will always be astring[]
.However, some htmlnano modules (
minifyJson
andminifySvg
) will transformnode.content
into astring
instead of astring[]
, so when other modules (which expectsnode.content
to be astring[]
) process the newnode.content
later on, htmlnano will crash.This PR fixes the issue by:
minifyJson
,minifySvg
, and other modules will always returnstring[]
.node.content
will always be cast into an array before passed intoonContent
.onContent
will always be cast into an array.cc @maltsev @AndrewKvalheim @mischnic @arneke