-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implements #127 #128
Conversation
@Scrum Also, what do you think about add |
I quickly skimmed the code. I like this new approach! Let me take a more detailed look over the weekend. @SukkaW did you do any speed benchmarks? |
Not "official" and correct benchmark approach, only tested on my own website, and it is indeed faster. It will be better if we have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An Official API provided by PostHTML that we can utilize.
Which one? Did they add something new in the recent releases?
I really appreciate you did such a big refactoring! It's really nice having such great contributors :-)
db5967f
to
69637b2
Compare
|
Name | Link |
---|---|
🔨 Latest commit | 69637b2 |
I pick up the PR, rewrite it, and make it ready for review. And here are the changes after the rewrite:
|
@maltsev I forgot to mark the PR as ready for review. |
Thanks! @SukkaW Unfortunately, I don't have time in the near future to do the proper review. But all your previous contributions were of top-notch quality. So I'm fine with just accepting this PR and releasing a new htmlnano version. Are you okay with that? |
Actually, I have already tested the PR on my own project (published as Also, the fix for #180 (#181) should be included in a new version, too. |
Awesome! I'm going to merge it now then. I'll release the new version in the coming days. |
I released the new version. |
I create a draft PR since It is just a Proof of Concept for #127. The PR is meant to allow for discussion and showing some refactoring issues going on.