build: disables coverage threshold for new files #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
| @@ -43,6 +43,4 @@ jobs: | |||
| with: | |||
| coverageFile: coverage.xml | |||
| thresholdAll: 0.8 | |||
| thresholdNew: 0.9 | |||
There was a problem hiding this comment.
Why, out of curiosity?
There was a problem hiding this comment.
It was causing CI to fail on files that were updated during refactoring. Similar to the behavior that drove the change to set thresholdAll: 0.8. I'd like to re-enable it soon once things have settled.
dbkegley
pushed a commit
that referenced
this pull request
Feb 21, 2024
* doc: put some words in README.md (#38) * feat: adds passthrough methods for each HTTP request type (#25) * feat: adds connect_version property to Client (#39) * build: disables coverage threshold for new files (#41) * ci: adds main.yaml (#42) * ci: fixes main.yaml job name (#43) --------- Co-authored-by: Neal Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.