Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds passthrough methods for each HTTP request type #25

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Feb 16, 2024

Adds methods to posit.connect.clients.Client for each HTTP request type. Each method simply modifies the matching requests method by appending the provided path to the base URL.

posit.connect.urls.Url is added to provide safe URL manipulation.

Copy link

github-actions bot commented Feb 16, 2024

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
459 411 90% 80% 🟢

New Files

File Coverage Status
src/posit/connect/urls.py 100% 🟢
src/posit/connect/urls_test.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/posit/connect/client.py 100% 🟢
src/posit/connect/client_test.py 100% 🟢
src/posit/connect/config.py 100% 🟢
src/posit/connect/config_test.py 100% 🟢
src/posit/connect/resources.py 52% 🔴
src/posit/connect/resources_test.py 97% 🟢
src/posit/connect/users.py 65% 🔴
TOTAL 88% 🔴

updated for commit: 1af9dad by action🐍

@tdstein tdstein force-pushed the tdstein/http-method-passthrough branch from 840627d to 6b8021d Compare February 16, 2024 17:47
@tdstein tdstein force-pushed the tdstein/http-method-passthrough branch from 6b8021d to b618061 Compare February 16, 2024 18:30
src/posit/connect/urls.py Outdated Show resolved Hide resolved
src/posit/connect/users.py Outdated Show resolved Hide resolved
@nealrichardson nealrichardson mentioned this pull request Feb 16, 2024
6 tasks
@tdstein tdstein force-pushed the tdstein/http-method-passthrough branch from b618061 to 2dee631 Compare February 21, 2024 15:41
@tdstein tdstein merged commit f0f4a8e into main Feb 21, 2024
6 of 7 checks passed
@tdstein tdstein deleted the tdstein/http-method-passthrough branch February 21, 2024 15:43
dbkegley pushed a commit that referenced this pull request Feb 21, 2024
* doc: put some words in README.md (#38)

* feat: adds passthrough methods for each HTTP request type (#25)

* feat: adds connect_version property to Client (#39)

* build: disables coverage threshold for new files (#41)

* ci: adds main.yaml (#42)

* ci: fixes main.yaml job name (#43)

---------

Co-authored-by: Neal Richardson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants