Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Webmock allowed requests to get chromedriver #670

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Edit Webmock allowed requests to get chromedriver #670

merged 2 commits into from
Feb 21, 2024

Conversation

aaronskiba
Copy link
Collaborator

Fixes #669

Changes proposed in this PR:

  • Edit Webmock's allowed request list to enable fetching of chromedriver (The selenium/features tests cannot be run without this change.).

200455939-yashu
200455939-yashu approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. 👏

@aaronskiba aaronskiba merged commit 466d57a into integration Feb 21, 2024
13 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/669 branch February 21, 2024 16:15
@aaronskiba aaronskiba mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@200455939-yashu 200455939-yashu 200455939-yashu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronskiba @200455939-yashu