Merge pull request #670 from portagenetwork/aaron/issues/669

Edit Webmock allowed requests to get chromedriver
portagenetwork · Feb 21, 2024 · 466d57a · 466d57a
2 parents e31c87c + 2254bb9
commit 466d57a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 - Bump mysql2 from 0.5.5 to 0.5.6 [#645](https://github.com/portagenetwork/roadmap/pull/645)
 
+### Fixed
+
+- Updated Webmock's allowed request list to enable fetching of chromedriver [#670](https://github.com/portagenetwork/roadmap/pull/670)
+
 ## [4.0.2+portage-4.0.0] - 2024-02-01
 
 ### Added

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -121,10 +121,9 @@
 
       # Allow Capybara to make localhost requests and also contact the
       # google api chromedriver store
-      # add googlechromelabs.github.io and edgedl.me.gvt1.com to work with Chrome v116+
       WebMock.disable_net_connect!(
         allow_localhost: true,
-        allow: %w[chromedriver.storage.googleapis.com googlechromelabs.github.io edgedl.me.gvt1.com]
+        allow: %w[storage.googleapis.com googlechromelabs.github.io]
       )
     end