Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] Refer to entity in upsert entity response #943

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[Framework] Refer to entity in upsert entity response #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d583716
refer to entity in upsert entity response
omby8888 Aug 26, 2024
e0892c6
bump version
omby8888 Aug 26, 2024
59df958
remove commented line
omby8888 Aug 26, 2024
5cd31c6
cr fixes
omby8888 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .idea/watcherTasks.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

<!-- towncrier release notes start -->

## 0.10.1 (2024-08-26)

### Bug Fixes

- Fixed unhashable type: 'dict' error when trying to delete entities with search identifier/relations


## 0.10.0 (2024-08-19)

### Improvements
Expand All @@ -17,7 +24,6 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## 0.9.14 (2024-08-19)


### Bug Fixes

- Fixed an issue causing the cli to fail in a directory with no pyproject.toml in it
Expand Down Expand Up @@ -128,7 +134,7 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Bug Fixes

- Safely get changelogDestination key instead of accessing it directly
- Safely get changelogDestination key instead of accessing it directly


## 0.9.0 (2024-06-19)
Expand Down Expand Up @@ -589,7 +595,7 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- Fixed kafka consumer to poll messages asynchronously, to avoid max poll timeout when running long resyncs (PORT-5160)
- Fixed a bug where the expiration of a Port token is not properly handled (PORT-5161)
- Fixed a bug where the `retry_every` didn't count failed runs as repetitions (PORT-5161)
- Fixed a bug where the `retry_every` didn't count failed runs as repetitions (PORT-5161)

## 0.4.2 (2023-11-04)

Expand Down Expand Up @@ -619,7 +625,7 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- Fixed the `initialize-port-resources` option in `ocean sail` to not be a flag.
- Changed default of `initialize-port-resources` to `true`.
- Catch all exceptions in the resync of ONCE event listener,to make sure the application will exit gracefully
- Catch all exceptions in the resync of ONCE event listener,to make sure the application will exit gracefully


## 0.4.0 (2023-10-31)
Expand Down
2 changes: 1 addition & 1 deletion port_ocean/clients/port/mixins/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async def upsert_entity(
)
handle_status_code(response, should_raise)
result = response.json()
result_entity = Entity.parse_obj(result)
result_entity = Entity.parse_obj(result["entity"])
matan84 marked this conversation as resolved.
Show resolved Hide resolved
# Set the results of the search relation and identifier to the entity
entity.identifier = result_entity.identifier or entity.identifier
entity.relations = result_entity.relations or entity.relations
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "port-ocean"
version = "0.10.0"
version = "0.10.1"
description = "Port Ocean is a CLI tool for managing your Port projects."
readme = "README.md"
homepage = "https://app.getport.io"
Expand Down