Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] Refer to entity in upsert entity response #943

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

omby8888
Copy link
Contributor

Description

What - Refer to entity in upsert entity response
Why - Response from upsert entity api isn't processed right and causes ocean core to use the raw entity that contains dict typed relation instead of string which is the relation's entity identifier
How - Simply refer to the entity key in a response that looks like {ok: true, entity: {...}}

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@omby8888 omby8888 requested a review from a team as a code owner August 26, 2024 07:15
@github-actions github-actions bot added size/S and removed size/XS labels Aug 26, 2024
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments

.idea/watcherTasks.xml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
port_ocean/clients/port/mixins/entities.py Show resolved Hide resolved
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omby8888 omby8888 merged commit fcdcd09 into main Aug 26, 2024
12 checks passed
@omby8888 omby8888 deleted the PORT-10064-Bug-search-relation-error-unhashable-dict branch August 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants