-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kusama: Make the current inflation formula adjustable. #364
Kusama: Make the current inflation formula adjustable. #364
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Simply updates the encointer-pallets to v1.14.0. Nothing else happened there in the meantime. cc @brenzi
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Some updates:
|
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
…llows#393) In the update to [sdk 1.14](polkadot-fellows#381) the `request_revenue_info` is now implemented but this call had been switched off when it was added in polkadot-fellows#212. This PR just enables this again in the coretime interface. cc @ggwpez @s0me0ne-unkn0wn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high-level looks good, did not double-check the actual staking initial values coded in
// ---- TODO: Above is copy pasted from sdk, remove once we pull the version containing | ||
// https://github.com/paritytech/polkadot-sdk/pull/4938 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better if you referenced the crate name and (min) version required, instead of this PR, otherwise it becomes a non-trivial chore to figure out when this can be removed and no one will do it :)
(same above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, some nits with docs/comments
type AdminOrigin = DynamicParameterOrigin; | ||
type WeightInfo = weights::pallet_parameters::WeightInfo<Runtime>; | ||
} | ||
|
||
pub struct EraPayout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub
with no docs
Co-authored-by: Dónal Murray <[email protected]>
/merge |
Enabled Available commands
For more information see the documentation |
4fd2981
into
polkadot-fellows:main
Trigger the v1.3.0 release with the following additional changes: - Bump `polkadot-runtime-parachains` version to get paritytech/polkadot-sdk#5369 in [63cb34d](63cb34d) and update tests in [e718c64](e718c64). - Filter calls to `interlace` on the Polkadot Coretime Chain until the relay implementation matures in [1126cf7](1126cf7). - Update all runtime versions to `1_003_000` in [08744df](08744df) TODO: - [x] Finalise changelog - [x] Wait for #433 - [x] Wait for #364 Closes #186 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Counterpart of #364. Similarly, it has no impact on the inflation as-is, and just exposes the params to the Root track. ## UI Consideration Similarly, it adds `Inflation_experimental_inflation_info` Runtime API, which can be used by UIs to fetch information about the inflation, without needing to rely on storage items. ## Example - With current parameters: ``` Inflation ==> staking = 402244.054 DOT (4,022,440,540,915,948) / leftover = 4178.285 DOT (41,782,856,835,356) ``` - With `UseLegacyAuctions = false`, which means we no longer set aside around 15% of tokens for auctions. This makes the difference between actual staked and ideal staking rate (staking inefficiency) grow, and therefore reduce the staking reward and increase the treasury income. ``` Inflation ==> staking = 340780.189 DOT (3,407,801,892,871,273) / leftover = 65642.150 DOT (656,421,504,843,446) ``` --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Gonçalo Pestana <[email protected]> Co-authored-by: Ankan <[email protected]>
This PR does not alter the inflation of Kusama, but instead make the current parameters of the system fully configurable.
Parameters
The parameters are as follows:
All of the above are exactly the current values in Kusama, and leave everything unchanged, leading to roughly
1kKSM
minted for validators, and around90KSM
for treasury.All of the above can be changed via the
Root
track only.Given that it is hard to come to consensus, I highly advise this PR (and a similar PR to Polkadot) to NOT alter any parameter and leave that to the token holders.
Just to provide one example, if we set
UseAuctionSlots = false
and leave everything else un-changed, the amount minted per era would be:807KSM
for staking238KSM
for treasuryConsideration for UIs
This PR is shipped with a new runtime API that is only added to the Kusama runtime:
Inflation_experimental_inflation_info
. I hope this API is used by the UIs to show the inflation parameters of the network, rather than re-creating the Rust logic in the front-end.