Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Westend Inflation Parameterize-able #4907

Closed
kianenigma opened this issue Jun 28, 2024 · 2 comments · Fixed by #4938
Closed

Make Westend Inflation Parameterize-able #4907

kianenigma opened this issue Jun 28, 2024 · 2 comments · Fixed by #4938
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@kianenigma
Copy link
Contributor

Move the inflation forumula of westend to closely resemble what is the intended outcome of polkadot-fellows/runtimes#364.

This allows us and the community to already test pallet-parameters.

The actual inflation function doesn't matter much. Important is to make some part of it configurable by the pallet-parameters. It would be best if it almost matches what is intended to go into Polkadot/Kusama so we can test everything.

Will be tipped :)
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Jun 28, 2024
@marcuspang
Copy link
Contributor

Hi @kianenigma, I would like to take up this issue if possible!

@kianenigma
Copy link
Contributor Author

Available! Please share a draft PR early on so we can collaborate :)

@marcuspang marcuspang mentioned this issue Jul 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2024
@marcuspang @kianenigma
feat: introduce pallet-parameters to Westend to parameterize inflation (
6e520eb 
#4938)

Fixes #4907

## Changes
- Add `pallet-parameters` to Westend runtime
- Add `relay_era_payout` function to Polkadot runtime common + deprecate
previous `era_payout` function
- Add unit tests for `relay_era_payout`, matching previous unit tests
for `era_payout`
- Remove `pallet_staking_reward_curve` in Westend runtime
- Add `dynamic_params` to replace constants used for
`pallet_staking_reward_curve`

Polkadot address: 5DybbVdLvVWd7MiA1YwkzLUNL1ThMDicozbuLc8v9pQEScPQ

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: kianenigma <[email protected]>
Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@marcuspang @kianenigma @TarekkMA
feat: introduce pallet-parameters to Westend to parameterize inflation (
3ec7751 
paritytech#4938)

Fixes paritytech#4907

## Changes
- Add `pallet-parameters` to Westend runtime
- Add `relay_era_payout` function to Polkadot runtime common + deprecate
previous `era_payout` function
- Add unit tests for `relay_era_payout`, matching previous unit tests
for `era_payout`
- Remove `pallet_staking_reward_curve` in Westend runtime
- Add `dynamic_params` to replace constants used for
`pallet_staking_reward_curve`

Polkadot address: 5DybbVdLvVWd7MiA1YwkzLUNL1ThMDicozbuLc8v9pQEScPQ

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: kianenigma <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce pallet-parameters to Westend to parameterize inflation marcuspang/polkadot-sdk
2 participants
@kianenigma @marcuspang