Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear error type #1216

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

boundless-forest
Copy link
Collaborator

// Used to record the external costs in the evm through the StackState implementation
let maybe_weight_info =
	WeightInfo::new_from_weight_limit(weight_limit, proof_size_base_cost).map_err(
		|_| RunnerError {
			error: Error::<T>::Undefined,
			weight,
		},
	)?;

The weight_limit.proof_size() < proof_size_base_cost case deserves a better error message with clear meaning.

@sorpaas sorpaas merged commit 849e712 into polkadot-evm:master Oct 15, 2023
4 checks passed
@boundless-forest boundless-forest deleted the bear-undefined-error branch October 16, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants