Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Undefined is ambiguous #1275

Closed
boundless-forest opened this issue Sep 20, 2023 · 2 comments · Fixed by #1516
Closed

The Undefined is ambiguous #1275

boundless-forest opened this issue Sep 20, 2023 · 2 comments · Fixed by #1516
Assignees
Labels
P-Mid [Priority] Median

Comments

@boundless-forest
Copy link
Member

boundless-forest commented Sep 20, 2023

// Used to record the external costs in the evm through the StackState implementation
let maybe_weight_info =
	WeightInfo::new_from_weight_limit(weight_limit, proof_size_base_cost).map_err(
		|_| RunnerError {
			error: Error::<T>::Undefined,
			weight,
		},
	)?;

The weight_limit.proof_size() < proof_size_base_cost case deserves a better error message with clear meaning.

@boundless-forest boundless-forest self-assigned this Sep 20, 2023
@boundless-forest
Copy link
Member Author

@hackfisher hackfisher added the P-Mid [Priority] Median label Mar 20, 2024
@boundless-forest
Copy link
Member Author

This will be fixed in the next frontier upgrade.

@boundless-forest boundless-forest linked a pull request Jun 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Mid [Priority] Median
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants