-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python)!: Change default engine for read_excel
to "calamine"
#17263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17263 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.01%
==========================================
Files 1475 1475
Lines 193162 193181 +19
Branches 2751 2756 +5
==========================================
- Hits 155922 155919 -3
- Misses 36732 36752 +20
- Partials 508 510 +2 ☔ View full report in Codecov by Sentry. |
3f985ac
to
3d60446
Compare
if is_file and str(source).lower().endswith(".ods"): | ||
# note: if called from "read_ods" the engine cannot be 'None', hence | ||
# this check is only triggered when called from "read_excel" | ||
msg = "OpenDocumentSpreadsheet files require use of `read_ods`, not `read_excel`" | ||
raise ValueError(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the logic wasn't being hit anymore since engine
cannot be None. Not sure if we still need this.
read_excel
to "calamine"
read_excel
to "calamine"
3d60446
to
4f824e9
Compare
@alexander-beedie for the |
Closes #17177
Changes
"calamine"
as the default engine forread_excel
for all file types, instead of only for.xlsb
and.xls
."calamine"
engine does not accept theengine_options
parameter (see example below).columns
parameter that can constrain which columns are returned (ref: Combineengine_options
andread_options
into a single parameter inread_excel
#17265).Example
Before:
After:
Instead, explicitly specify the
xlsx2csv
engine or omit theengine_options
: