Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over default engine for read_excel from "xlsx2csv" to "calamine" #17177

Closed
stinodego opened this issue Jun 25, 2024 · 0 comments · Fixed by #17263
Closed

Switch over default engine for read_excel from "xlsx2csv" to "calamine" #17177

stinodego opened this issue Jun 25, 2024 · 0 comments · Fixed by #17263
Assignees
@alexander-beedie @stinodego
Labels
A-io-spreadsheet Area: reading/writing Excel/ODS files accepted Ready for implementation enhancement New feature or an improvement of an existing feature
Milestone
1.0.0

Comments

@stinodego
Copy link
Member

stinodego commented Jun 25, 2024 •
edited
Loading

The calamine engine (through the fastexcel package) is the faster engine and we believe it is solid enough to be our default.

Some context here:
#15808 (comment)
@stinodego stinodego added the enhancement New feature or an improvement of an existing feature label Jun 25, 2024
@alexander-beedie alexander-beedie self-assigned this Jun 25, 2024
@alexander-beedie alexander-beedie added the A-io-spreadsheet Area: reading/writing Excel/ODS files label Jun 25, 2024
@stinodego stinodego added this to the 1.0.0 milestone Jun 25, 2024
This was referenced Jun 28, 2024
Merged
Merged
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
@c-peters c-peters moved this to Done in Backlog Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-beedie alexander-beedie

@stinodego stinodego

Labels
A-io-spreadsheet Area: reading/writing Excel/ODS files accepted Ready for implementation enhancement New feature or an improvement of an existing feature
Projects
Backlog
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

feat(python)!: Change default engine for read_excel to "calamine" pola-rs/polars
3 participants
@alexander-beedie @stinodego @c-peters