Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove && operator from chained git commands #67

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

NathanJang
Copy link
Contributor

Split git commands to multiple calls to runCommand. Instead of using the bash operator && to chain multiple git commands, we can chain them by chaining the promises from runCommand.

Fixes #64. This prevents the commands from failing when the shell doesn't support &&, like in fish. Closes #66, but thanks to them for pointing out the points where it fails.

@knownasilya knownasilya merged commit 820b462 into poetic:master Nov 6, 2018
@knownasilya
Copy link
Contributor

Thanks 👍

knownasilya added a commit that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants