Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if the default bash is FISH #64

Closed
mayank8318 opened this issue May 21, 2018 · 9 comments
Closed

Fails if the default bash is FISH #64

mayank8318 opened this issue May 21, 2018 · 9 comments

Comments

@mayank8318
Copy link

No description provided.

@knownasilya
Copy link
Contributor

knownasilya commented May 21, 2018

Is there a specific error and what command are you running?

@mayank8318
Copy link
Author

mayank8318 commented May 21, 2018

@knownasilya Yes in the runCommand() method && is causing the problem. FISH requires it to be ; and. Sorry didn't mention that

@knownasilya
Copy link
Contributor

I probably won't be able to get to this issue this week, but would be able to review a PR if you feel up to it.

@mayank8318
Copy link
Author

@knownasilya I will try if I can find a fix. I fixed it by Find and Replace (there are only 3 occurrences). But I am not sure if this will work on other terminals. Worked on FISH

@knownasilya
Copy link
Contributor

You might have to do a conditional to check if using fish and use alternate syntax.

@mayank8318
Copy link
Author

@knownasilya Yes, I will try to solve it and open a PR if I am successful. I will let you know :)

@devotox
Copy link

devotox commented Aug 11, 2018

Fixes here
#66

@NathanJang
Copy link
Contributor

Hi all, I have made a PR at #67, which tries to fix the issue more gracefully. It appears to work so far for my use cases. Please let me know if there are any issues.

@knownasilya
Copy link
Contributor

Should be released in v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants